Switch to standard types, replace long types #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes `<cstdint>` and updates typedefs to point to it so that I don't need to go around the entire source and update every single type. Replace `long` with `int` in any place where the type is used for a plain value. This clarifies that nothing is broken here. Generally use `int` as the "don't care" type. `int` always means `int32_t` on modern compilers on all platforms. This is convention. `unsigned long` becomes `uint32_t`. `printf` function which was converting pointers to int to print them now uses `%p` instead to print the pointer directly. `EffectInfo::Source` is a suspicious union of pointer and enum types. I used `intptr_t` here for comparisons to prevent truncation. Did not touch `long` in preprocessor or tokenizer sources.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
<cstdint>and updates typedefs to point to it so that I don't need to go around the entire source and update every single type.Replace
longwithintin any place where the type is used for a plain value. This clarifies that nothing is broken here.Generally use
intas the "don't care" type.intalways meansint32_ton modern compilers on all platforms. This is convention.unsigned longbecomesuint32_t.printffunction which was converting pointers to int to print them now uses%pinstead to print the pointer directly. This might be left over debug code actually.EffectInfo::Sourceis a suspicious union-like type of pointer and enum types. I usedintptr_there for comparisons to prevent truncation.Did not touch
longin preprocessor or tokenizer sources. Not much I can do with these for now.